Fixed TypeDoc generation in PBU#1927
Merged
Merged
Conversation
tjcouch-sil
requested review from
irahopkinson,
jolierabideau,
lyonsil and
rolfheij-sil
as code owners
jolierabideau
approved these changes
Nov 20, 2025
jolierabideau
left a comment
jolierabideau
left a comment
Collaborator
There was a problem hiding this comment.
Typedoc can be so frustrating, thanks for working on this!
@jolierabideau reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeDoc documentation build failure: https://github.com/paranext/paranext-core/actions/runs/19511634364/job/55852599399
Added XML as a language it can generate docs for (the others I put in the list are default, but I can't mention that in a comment because
typedoc.jsonis JSON :/ ). No idea why it doesn't just allow all whose grammar it knows. Also ignored USFM so it doesn't throw a bunch of warnings that it doesn't know that grammar. Also no idea why it warns on USFM but errors on XML.Corresponding PR in
usfm-toolsto fix some smaller warnings: paranext/usfm-tools#2This change is